Remove XXXRawSyntax.withYYY() methods #1048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should save some code size.
|
@swift-ci Please test |
bnbarham
reviewed
Nov 3, 2022
| @@ -167,7 +167,13 @@ extension Parser { | |||
| arena: parser.arena) | |||
| } addSemicolonIfNeeded: { lastElement, newItemAtStartOfLine, parser in | |||
| if lastElement.semicolon == nil && !newItemAtStartOfLine { | |||
| return lastElement.withSemicolon(parser.missingToken(.semicolon, text: nil), arena: parser.arena) | |||
There was a problem hiding this comment.
Totally fine with this change for now. But one thing I was thinking of... What if we instead had just a single .with that takes the previous node + optional params + leading/trailing trivia? For both the red + green tree. Then this would be eg.
return RawMemberDeclListItemSyntax(lastElement, semicolon: parser.missingToken(.semicolon, text: nil)))
EDIT: Actually, thinking about this more - it's probably not worth it for the green tree. We really shouldn't be modifying them very much (ideally not at all but... 🤷). So for the green tree we'd just have the initializers (no with's) and for the red tree each would have a single .with(...).
CodaFi
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should save some code size.