Prepare SwiftParser for Library Evolution #1095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There appears to be an unhandled case where a _read accessor yields the result of an unsafe addressor. rdar://102247545 tracks the SIL-side problem. For now, swap the _read access for a plain getter.
When Library Evolution is enabled, this protocol requires its @_spi members to have default implementations. For one, there's not really a reasonable default implementation we could provide. For another, there's not really a way one could conform to this protocol without also having SPI access to raw tokens from the lexer. Lift the SPI restriction to the entire protocol and refactor the conformances a bit.
|
@swift-ci test |
DougGregor
approved these changes
Nov 29, 2022
rintaro
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TokenConsumerto avoid Library Evolution restrictions.