Add a detach() to syntax nodes
#1103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
approved these changes
Dec 2, 2022
|
@swift-ci please test |
ahoppen
reviewed
Dec 3, 2022
Cases where you want to pass around a subtree without access to the rest of the tree. |
Allow clients to detach (ie. re-root) a syntax tree. Also remove `RawSyntaxToSyntax` since this should only be used by this parser, which can just use the `Syntax` constructor directly instead.
|
@swift-ci please test |
ahoppen
approved these changes
Dec 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow clients to detach (ie. re-root) a syntax tree.
Also remove
RawSyntaxToSyntaxsince this should only be used by this parser, which can just use theSyntaxconstructor directly instead.