Skip to content

Fix parsing generic argument lists of variadic types in expression context #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

slavapestov
Copy link
Contributor

We need to allow empty argument lists, and accept '...' in canParseType().

@slavapestov slavapestov requested a review from ahoppen as a code owner December 6, 2022 03:21
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test case?

@slavapestov
Copy link
Contributor Author

@swift-ci Please smoke test

@slavapestov
Copy link
Contributor Author

@swift-ci Please test

@slavapestov
Copy link
Contributor Author

@ahoppen I added a couple of tests. The syntax will likely change very soon anyway, as per the discussion on the forums.

…ntext

We need to allow empty argument lists, and accept '...' in canParseType().
@slavapestov
Copy link
Contributor Author

@swift-ci Please test

Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the test cases. LGTM

@slavapestov slavapestov merged commit 9b80b6b into swiftlang:main Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants