Improve diagnostics of #available and #unavailable
#1125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
ahoppen
force-pushed
the
ahoppen/availability-diags
branch
from
14eae8f to
955121b
Compare
|
@swift-ci Please test |
ahoppen
force-pushed
the
ahoppen/availability-diags
branch
from
955121b to
b121d2e
Compare
|
@swift-ci Please test |
ahoppen
force-pushed
the
ahoppen/availability-diags
branch
from
b121d2e to
fc6048d
Compare
|
@swift-ci Please test |
bnbarham
approved these changes
Jan 12, 2023
Tests/SwiftParserTest/translated/AvailabilityQueryUnavailabilityTests.swift
Outdated
Show resolved
Hide resolved
| if unexpected.first?.as(TokenSyntax.self)?.tokenKind == .pound { | ||
| addDiagnostic(unexpected, UnknownDirectiveError(unexpected: unexpected), handledNodes: [unexpected.id, node.identifier.id]) | ||
| } else if let availability = unexpected.first?.as(AvailabilityConditionSyntax.self) { | ||
| if let prefixOperatorExpr = node.parent?.as(PrefixOperatorExprSyntax.self), |
There was a problem hiding this comment.
Might be worth splitting this out into its own method
There was a problem hiding this comment.
I factored out the logic for negatedAvailabilityKeyword. With that I think the logic is pretty straightforward again.
ahoppen
force-pushed
the
ahoppen/availability-diags
branch
from
fc6048d to
e4eb030
Compare
These two nodes were pretty much always handled the same, we should just have one node definition for it.
ahoppen
force-pushed
the
ahoppen/availability-diags
branch
from
e4eb030 to
4e85fa4
Compare
ahoppen
force-pushed
the
ahoppen/availability-diags
branch
from
4e85fa4 to
5272e00
Compare
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves most TODOs in AvailabilityQueryTests.swift and UnavailabilityQueryTests.swift