Remove Unknown Syntax Nodes #1131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
CodaFi
force-pushed
the
known-unknowns
branch
2 times, most recently
from
8f8de4f to
e1b7bb9
Compare
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
CodaFi
added a commit
to swiftlang/swift-format
that referenced
this pull request
Dec 11, 2022
The new Swift parser in SwiftSyntax does not ever construct Unknown*Syntax nodes. These are a relic of the C++, which would use these nodes as stand-ins for cases where the legacy parser did not known how to build a node, or built one incorrectly. Simultaneously, the formatter was relying on unknown nodes containing verbatim text it would leave untouched. The general replacement for that case is UnexpectedSyntax. Drop the Unknown*Syntax entrypoints in the visitors, and replace refernces to "unknown syntax" with "unexpected syntax". See also swiftlang/swift-syntax#1131
This was referenced Dec 11, 2022
CodaFi
force-pushed
the
known-unknowns
branch
from
9da565b to
c1dd346
Compare
These were used by libSyntax to indicate that it had encountered something malformed or that it couldn't represent. This does not fit into the new parser's resilience model, so we no longer need these nodes.
CodaFi
force-pushed
the
known-unknowns
branch
from
c1dd346 to
f3cb538
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were used by libSyntax to indicate that it had encountered something malformed or that it couldn't represent. This does not fit into the new parser's resilience model, so we no longer need these nodes.