Remove __FILE__ et al as keywords and syntax nodes.
#1135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were keywords prior to Swift 2, and have only been kept around as keywords to provide a custom error message to rewrite to `#file` et al. It's incorrect to keep them as keywords, and that error should be implemented differently if we care about it.
|
@swift-ci please test |
With __FILE__ et al no longer being keywords, the parser is no longer forming these syntax nodes. They are all handled as macro expansion expression nodes.
DougGregor
changed the title
__FILE__ et al as keywords.__FILE__ et al as keywords and syntax nodes.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__FILE__,__COLUMN__, et al were keywords prior to Swift 2, and have only been kept around as keywords to provide a custom error message to rewrite to#file,#column, etc. It's incorrect to keep them as keywords, and that error should be implemented differently if we care about it.These keywords were the only things keeping the syntax nodes for
#fileet al around; the correct spellings like#fileare now macro expansion expression syntax nodes. So, remove these syntax nodes as well.