Stop using TokenList and NonEmptyTokenList
#1177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
ahoppen/no-tokenlist
branch
from
5cd3e3f to
75e6341
Compare
ahoppen
changed the title
TokenList and NonEmptyTokenList 🚥 #1176TokenList and NonEmptyTokenList
ahoppen
force-pushed
the
ahoppen/no-tokenlist
branch
from
75e6341 to
0d1f936
Compare
|
@swift-ci Please test |
ahoppen
force-pushed
the
ahoppen/no-tokenlist
branch
from
0d1f936 to
795620a
Compare
ahoppen
changed the title
TokenList and NonEmptyTokenListTokenList and NonEmptyTokenList 🚥 #1226
ahoppen
force-pushed
the
ahoppen/no-tokenlist
branch
from
795620a to
0f9e424
Compare
ahoppen
changed the title
TokenList and NonEmptyTokenList 🚥 #1226TokenList and NonEmptyTokenList
|
@swift-ci Please test |
ahoppen
force-pushed
the
ahoppen/no-tokenlist
branch
from
0f9e424 to
2bcaa31
Compare
|
@swift-ci Please test |
ahoppen
force-pushed
the
ahoppen/no-tokenlist
branch
from
2bcaa31 to
a85535b
Compare
|
@swift-ci Please test |
bnbarham
approved these changes
Jan 13, 2023
| @@ -374,13 +374,19 @@ | |||
| Child('Type', kind='Type'), | |||
| ]), | |||
|
|
|||
| Node('ClosureCaptureItemSpecifier', name_for_diagnostics='closure capture specifier', kind='Syntax', | |||
There was a problem hiding this comment.
Are there existing tests for this? If not it would be good to add a few.
There was a problem hiding this comment.
ahoppen
force-pushed
the
ahoppen/no-tokenlist
branch
from
a85535b to
ffefcda
Compare
|
@swift-ci Please test |
|
@swift-ci Please test macOS |
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
ahoppen
force-pushed
the
ahoppen/no-tokenlist
branch
from
ffefcda to
267a56c
Compare
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TokenListandNonEmptyTokenListare anti-patterns for SwiftSyntax parsing because they provide no structure. Stop using them.