Skip to content

Generate SyntaxAnyVisitor.swift #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2023

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Jan 5, 2023

SyntaxAnyVisitor.swift was missing from the template list in GenerateSwiftSyntax.

SyntaxAnyVisitor.swift was missing from the template list in GenerateSwiftSyntax.
@ahoppen ahoppen requested review from kimdv and hborla January 5, 2023 17:52
@ahoppen
Copy link
Member Author

ahoppen commented Jan 5, 2023

@swift-ci Please test

@kimdv
Copy link
Contributor

kimdv commented Jan 5, 2023

Should we do something like gyb, where we delete files before generating ?

To avoid this?

@ahoppen
Copy link
Member Author

ahoppen commented Jan 5, 2023

Should we do something like gyb, where we delete files before generating ?

To avoid this?

I think that would be good

@hborla
Copy link
Member

hborla commented Jan 7, 2023

Thank you! Merging this to unblock #1167

@hborla hborla merged commit 12cbda5 into swiftlang:main Jan 7, 2023
@ahoppen ahoppen deleted the ahoppen/generate-syntaxanyvisitor branch January 14, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants