[Macros] Implement peer declaration macros with expansion #1196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peer declaration macros are applied to a declaration via an attribute,
but are responsible for generating "peer" declarations that go
alongside the declaration to which the attribute is attached.
Implement the `addCompletionHandler` example, which takes:
@addCompletionHandler
func f(a: Int, for b: String, _ value: Double) async -> String { }
and adds the following peer declaration:
func f(a: Int, for b: String, _ value: Double,
completionHandler: (String) -> Void) {
Task {
completionHandler(await f(a: a, for: b, value))
}
}
This makes sure we eliminate the macro uses from the resulting source file.
|
@swift-ci please test |
rxwei
reviewed
Jan 7, 2023
| @@ -12,7 +12,6 @@ | |||
|
|
|||
| import SwiftSyntax | |||
| import SwiftParser | |||
There was a problem hiding this comment.
Looks like SwiftParser isn't needed here either
There was a problem hiding this comment.
You're right, the macro protocols have a bunch of extra imports. I've cleaned them up locally.
|
@swift-ci please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Peer declaration macros are applied to a declaration via an attribute,
but are responsible for generating "peer" declarations that go
alongside the declaration to which the attribute is attached.
Implement the
addCompletionHandlerexample, which takes:and adds the following peer declaration: