Save 2 bytes in RawSyntaxData.ParsedToken
#1219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduction of `LexerError` incrased the `ParsedToken` size by 2 bytes compared to storing the kind and offset separately. `MemoryLayoutTest` didn’t fail because we only run them for debug builds but CI only creates release builds. Reclaim those two bytes by storing kind and offset as two fields in `RawSyntaxData.ParsedToken` again and transparently mapping them to a `LexerError` on access.
|
@swift-ci Please test |
|
Comment on https://github.com/apple/swift-syntax/pull/1191/files |
rintaro
reviewed
Jan 11, 2023
Yeah, this one is far smaller than the others - so I'm not sure we really need this change, shall we just update the test instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction of
LexerErrorincrased theParsedTokensize by 2 bytes compared to storing the kind and offset separately.MemoryLayoutTestdidn’t fail because we only run them for debug builds but CI only creates release builds.Reclaim those two bytes by storing kind and offset as two fields in
RawSyntaxData.ParsedTokenagain and transparently mapping them to aLexerErroron access.