Implement more lexer diagnostics #1245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
ahoppen/99-lexing-backlog
branch
from
8db5890 to
0fec4fc
Compare
ahoppen
changed the title
|
@swift-ci Please test |
bnbarham
reviewed
Feb 1, 2023
| @@ -474,6 +474,9 @@ extension FixItMessage where Self == StaticParserFixIt { | |||
| public static var replaceCurlyQuoteByNormalQuote: Self { | |||
| .init(#"replace curly quotes by '"'"#) | |||
| } | |||
| public static var replaceNonBreakingSpaceBySpace: Self { | |||
| .init("replace non-breaking space by ' '") | |||
There was a problem hiding this comment.
by -> with? Same above this one as well
There was a problem hiding this comment.
Interesting. I would have always said by but Google agrees that with is preferred. This also changes the ReplaceTokensFixIt, so I’ll do it in a follow-up PR.
ahoppen
force-pushed
the
ahoppen/99-lexing-backlog
branch
2 times, most recently
from
7474459 to
6c9b223
Compare
|
@swift-ci Please test |
bnbarham
reviewed
Feb 1, 2023
| let error = result.error.map { error in | ||
| return LexerError(error.kind, byteOffset: cursor.distance(to: error.position)) | ||
| } | ||
| error = error ?? result.error.map { LexerError($0.kind, byteOffset: cursor.distance(to: $0.position)) } |
There was a problem hiding this comment.
Could we add a conversion method on LexingError that takes the cursor?
struct LexingError {
...
func toLexerError(_ initialCursor: Cursor) {
return LexerError(kind, initialCursor.distance(to: position)
}
}
...
error = error ?? result.error?.toLexerError(cursor)
6c9b223 to
3f7b8a6
Compare
|
@swift-ci Please test |
…id identifier starts
Fixes swiftlang#1214 rdar://104082735
ahoppen
force-pushed
the
ahoppen/99-lexing-backlog
branch
from
6a28005 to
139f9df
Compare
|
@swift-ci Please test |
ahoppen
added a commit
to ahoppen/swift-syntax
that referenced
this pull request
Feb 7, 2023
As discussed in swiftlang#1245 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a few more lexer diagnostics.
Each commit of this PR should be standalone and should be reviewable on its own. But since they all build on top of each other, I can’t really create separate PRs for them.