[Macros] Rename macros to match recent pitches #1259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please test macOS |
odnoletkov
reviewed
Apr 18, 2023
There was a problem hiding this comment.
@DougGregor not sure you aware, but the change in c2741e4 did not just simplify the implementation, but also fixed an issue in SyntaxProtocol.token(at:). The old version was not lazy due to (I think) LazyMapSequence.first coercing Base to Collection. So the old version was unusably slow for anything outside trivial inputs.
Yet another example of Swift's lazy API being barely usable..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bringing things up to date with the pitches, at least for macro names. There's still more to do here for argument labels and
asyncindication. rdar://104567818