[Macros] Freestanding macros expand to CodeBlockItemList; parse top-level macro expansion decls #1268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parse freestanding macro expansions as declarations rather than expressions when it's not part of a statement or expression (i.e. "top-level").
…evel macro expansion decls - Change the return type of `FreestandingDeclarationMacro.expanion(of:in:)` to ``CodeBlockItemListSyntax` to allow expressions, statements, and declarations. - Parse freestanding macro expansions as declarations rather than expressions when it's not part of a statement or expression (i.e. "top-level").
rxwei
force-pushed
the
declaration-macro-name-lookup
branch
from
4d34529 to
e540b7c
Compare
ahoppen
reviewed
Jan 26, 2023
| @@ -16,5 +16,5 @@ public protocol CodeItemMacro: FreestandingMacro { | |||
| static func expansion( | |||
| of node: MacroExpansionDeclSyntax, | |||
| in context: inout MacroExpansionContext | |||
| ) throws -> [CodeBlockItemSyntax] | |||
| ) throws -> CodeBlockItemListSyntax | |||
There was a problem hiding this comment.
I discussed this with @DougGregor yesterday. If you are intending to merge these items with other items, this should return an array IMO because arrays are easier to work with (you can append, insert, delete, …). IMO you should only create a CodeBlockItemListSyntax once you think the item list is complete.
(similar in DeclarationMacros.swift)
There was a problem hiding this comment.
Good point! In that case this PR is no longer necessary. DeclarationMacro still returns decls, ExpressionMacro still returns exprs, and CodeItemMacro returns [CodeBlockItemSyntax]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FreestandingDeclarationMacro.expanion(of:in:)to ``CodeBlockItemListSyntax` to allow expressions, statements, and declarations.