Shorten getters and setters of syntax nodes #1270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimdv
approved these changes
Jan 25, 2023
ahoppen
changed the title
This makes the `Syntax*Nodes.swift` more succinct and easier to read
ahoppen
force-pushed
the
ahoppen/shorten-getter-and-setters
branch
from
4b46c2e to
355588e
Compare
|
@swift-ci Please test |
bnbarham
reviewed
Jan 27, 2023
| @@ -187,21 +187,14 @@ public struct ${node.name}: ${base_type}Protocol, SyntaxHashable { | |||
| % end | |||
| public var ${child.swift_name}: ${child_type}${optional_mark} { | |||
| get { | |||
There was a problem hiding this comment.
Could go even furtherrrr if you wanted to, ie. get/set on the same line as the body. Or does swift-format not like that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the
Syntax*Nodes.swiftmore succinct and easier to read