Skip to content

Update swift-syntax #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2023
Merged

Update swift-syntax #1273

merged 1 commit into from
Jan 30, 2023

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Jan 26, 2023 •
edited
Loading

Depends on #1287

@kimdv kimdv requested a review from ahoppen as a code owner January 26, 2023 07:48
@kimdv kimdv force-pushed the kimdv/update-swift-syntax branch from 466cbf3 to 244118b Compare January 26, 2023 07:49
ahoppen
ahoppen approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Those variable decls are a lot easier to read.

Can we wait for #1253 to be merged before merging this PR? I’ve been trying to get that PR merged for a couple of days now and constantly faced merge conflicts in one of the repos it touches. 😢

@kimdv
Copy link
Contributor Author

kimdv commented Jan 26, 2023

Nice. Those variable decls are a lot easier to read.

A lot easier!

Can we wait for #1253 to be merged before merging this PR? I’ve been trying to get that PR merged for a couple of days now and constantly faced merge conflicts in one of the repos it touches. 😢

I will wait and update code-gen if needed :D

@kimdv kimdv force-pushed the kimdv/update-swift-syntax branch from 244118b to 3b7807f Compare January 26, 2023 14:39
@ahoppen
Copy link
Member

ahoppen commented Jan 26, 2023

#1253 is merged now so we can land this PR.

@swift-ci Please test

@kimdv kimdv force-pushed the kimdv/update-swift-syntax branch 5 times, most recently from e0fbd9f to 04e2731 Compare January 29, 2023 16:57
@kimdv kimdv mentioned this pull request Jan 29, 2023
Merged
ahoppen
ahoppen approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this big update of CodeGeneration 🙏

@ahoppen
Copy link
Member

ahoppen commented Jan 30, 2023

@swift-ci Please test

@kimdv
Copy link
Contributor Author

kimdv commented Jan 30, 2023

Even tough we do a lot of try! 🫣
When #1287 is merged, we will update with a follow up PR

@ahoppen
Copy link
Member

ahoppen commented Jan 30, 2023

Yes, let’s try to get rid of the try! in follow-up PRs.

@kimdv kimdv force-pushed the kimdv/update-swift-syntax branch from 04e2731 to 15f84dc Compare January 30, 2023 17:21
@kimdv kimdv force-pushed the kimdv/update-swift-syntax branch from 15f84dc to 8441cc8 Compare January 30, 2023 17:32
@kimdv
Copy link
Contributor Author

kimdv commented Jan 30, 2023

@swift-ci please test

@kimdv kimdv merged commit eb5b363 into swiftlang:main Jan 30, 2023
@kimdv kimdv deleted the kimdv/update-swift-syntax branch January 30, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen ahoppen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kimdv @ahoppen