Remove parsing, token, and syntax nodes for # things subsumed by macros
#1284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
ahoppen
approved these changes
Jan 26, 2023
| @@ -52,7 +49,7 @@ final class PoundAssertTests: XCTestCase { | |||
| #assert(1️⃣, "error message") | |||
| """#, | |||
| diagnostics: [ | |||
| DiagnosticSpec(message: "expected condition in '#assert' directive") | |||
| DiagnosticSpec(message: "expected value in pound literal declaration") | |||
There was a problem hiding this comment.
Shouldn’t this be expected value in macro expansion? I think you need to update the name_for_diagnostics for MacroExpansionDecl.
There was a problem hiding this comment.
I suppose we can do that now. Previously, we decided to call them "pound literals" because we macros weren't a thing yet.
DougGregor
force-pushed
the
remove-pound-assert
branch
from
b1fda56 to
bb2d977
Compare
DougGregor
changed the title
# things subsumed by macros
|
@swift-ci please test |
It's subsumed by macro expansion declarations.
Macros are a thing now, yo
DougGregor
force-pushed
the
remove-pound-assert
branch
from
74f47b0 to
5ea331a
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a number of
#-related things that are subsumed by macros from the parser, token list, and syntax tree:#assert, an experimental feature#warningand#error, to be subsumed by freestanding macros#_hasSymbol, to be subsumed by a builtin expression macro#fileLiteral,#colorLiteral, and#imageLiteral