Fix two assertion failures related to invalid UTF-8 #1286
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
false
if we reached the end of the file, while it should returntrue
.SourceLocationConverter
previously worked onString
, which is lossy if the source contains invalid UTF-8. Make it work onSyntaxText
andRawTriviaPiece
so it’s source accurate.While at it, also fix a few things in
swift-parser-cli
:swift-parser-cli print-diags
String
.