Rework MacroExpansionContext and macro protocols
#1288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The macros design has moved to having `MacroExpansionContext` be a class-bound protocol. Adjust the implementation accordingly, and add a `TestingMacroExpansionContext` for a concrete implementation to use in test cases. And since I didn't want to break the `#fileID` macro that used to work, implement a general scheme for getting the location of a syntax node :).
DougGregor
changed the title
MacroExpansionContext as a protocolMacroExpansionContext and macro protocols
Make the signature generic over all freestanding macro expansion syntax nodes (to account for places where we parse as a declaration), and generic over the macro expansion context (lest we cause an existential crisis).
The bounds aren't quite what I was hoping for, because we don't have a way to abstract over "nodes that have accessors".
This is intended to be it's final name.
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@swift-ci please test |
|
@swift-ci please test Linux |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request collects together a number of changes to the API of the SwiftSyntaxMacros package to bring it into line with the proposals. It includes:
MacroExpansionContextis now a protocolBasicMacroExpansionContextis an implementation ofMacroExpansionContextthat is suitable for testing and similar clientsMacroExpansionContextadds alocation(of:)operation to get a source location for a given syntax node.#columnis back to being expressible as a macro ;)*Macroprotocols have been reworked and genericizedSwiftSyntaxMacros.