Allow node children to override whether a token needs a leading/trailing space #1298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimdv
approved these changes
Jan 31, 2023
bnbarham
approved these changes
Jan 31, 2023
|
That test will only be broken by #1180 |
ahoppen
changed the title
ahoppen
force-pushed
the
ahoppen/space-by-keypath
branch
from
f0eb715 to
6ee5d3b
Compare
|
@swift-ci Please test |
…ing space The motivating example was that we should not add a space after `for` in `@_dynamicReplacement(for:…)`. IMO, this also cleans up a few rules in BasicFormat.
ahoppen
force-pushed
the
ahoppen/space-by-keypath
branch
from
6ee5d3b to
8781308
Compare
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivating example was that we should not add a space after
forin@_dynamicReplacement(for:…).IMO, this also cleans up a few rules in BasicFormat.