Make Diagnostic initializers public #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For tools that use SwiftSyntax, it's quite useful to be able to emit their own diagnostics while reusing the `Diagnostic` type from SwiftSyntax. Both `Diagnostic` and its `Builder` type are `public`, and properties of `Diagnostic` are `public` too, but initializers are implicitly `internal`. This means that instances of `Diagnostic` can't be created by tools using SwiftSyntax. I hope this can be fixed with this simple change.
nkcsgexi
approved these changes
Jun 11, 2019
There was a problem hiding this comment.
@MaxDesiatov Welcome to the project! Allowing SwiftSyntax clients to use the same diagnostic type seems beneficial to me.
|
@swift-ci please test |
adevress
pushed a commit
to adevress/swift-syntax
that referenced
this pull request
Jan 14, 2024
Swap order of .close and .break around tuple exprs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For tools that use SwiftSyntax, it's quite useful to be able to emit their own diagnostics while reusing the
Diagnostictype from SwiftSyntax. BothDiagnosticand itsBuildertype arepublic, and properties ofDiagnosticarepublictoo, but initializers are implicitlyinternal. This means that instances ofDiagnosticcan't be created by tools using SwiftSyntax. I hope this can be fixed with this simple change.