Remove convenience initializers

[kimdv]

No description provided.

[kimdv]

@swift-ci please test

[ahoppen]

Thank you.

I just went through the convenience initializers as well and think the following changes would also make sense. If you’ve got time, I think it would be good to do them in this PR. But we can also merge this as-is and I’ll create a follow-up PR

• FunctionParameterSyntax should take a PartialSyntaxNodeString instead of a String
• I think SwitchCaseSyntax could also be represented as a convenience initializer in SyntaxNodeWithBody.swift
• Rename the MARK: CustomAttribute to MARK: Attribute and sort it to the top of the file to maintain alphabetical order

[kimdv]

Will add them to this PR

[kimdv]

@ahoppen should TupleExprElementSyntax I also replace the string with an PartialSyntaxNodeString and then change to label: label.map { TokenSyntax("\($0)") }

[kimdv]

Also removed the one from IfStmtSyntax as there is one in SyntaxNodeWithBody.swift

[kimdv]

Also removed TernaryExprSyntax as we can use ExprSyntax now

[kimdv]

@swift-ci please test

[ahoppen]

@ahoppen should TupleExprElementSyntax I also replace the string with an PartialSyntaxNodeString and then change to label: label.map { TokenSyntax("\($0)") }

For TupleExprElementSyntax it’s fine since we aren’t parsing the string – we are using it as the contents of an identifier.

[ahoppen]

Thank you!

[ahoppen]

@swift-ci Please test

[kimdv]

@swift-ci please test