When a token has both a lexer warning and a lexer error, report the error #1321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rror Otherwise, we would be surpressing lexer errors by warnings, accepting source code that should be invalid.
ahoppen
force-pushed
the
ahoppen/prefer-error-over-warning
branch
from
dbd0bd3 to
d37fe3b
Compare
ahoppen
changed the title
|
@swift-ci Please test |
|
@swift-ci Please test macOS |
bnbarham
approved these changes
Feb 8, 2023
|
@swift-ci Please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, we would be suppressing lexer errors by warnings, accepting source code that should be invalid.