Skip to content

Fix colon followed by right paren spacing #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2023
Merged

Fix colon followed by right paren spacing #1324

merged 1 commit into from
Feb 9, 2023

Conversation

kimdv
Copy link
Contributor

@kimdv kimdv commented Feb 8, 2023

No description provided.

@kimdv kimdv requested a review from ahoppen as a code owner February 8, 2023 11:31
@kimdv
Copy link
Contributor Author

kimdv commented Feb 8, 2023

@swift-ci please test

ahoppen
ahoppen reviewed Feb 8, 2023
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what you want to do, is mark the colon in DeclNameArgument as not requiring a space so that we also don’t insert a space after raw: in Foo.init(raw:otherParam:).

@kimdv kimdv force-pushed the kimdv/fix-spacing-for-colon-and-right-paren branch from a0464df to 9a3623b Compare February 9, 2023 06:54
@kimdv
Copy link
Contributor Author

kimdv commented Feb 9, 2023

Nice, thanks Alex!

@kimdv
Copy link
Contributor Author

kimdv commented Feb 9, 2023

@swift-ci please test

ahoppen
ahoppen approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@kimdv kimdv merged commit b4c5149 into swiftlang:main Feb 9, 2023
@kimdv kimdv deleted the kimdv/fix-spacing-for-colon-and-right-paren branch February 9, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen ahoppen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kimdv @ahoppen