Skip to content

Introduce SyntaxVisitorBase #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2019
Merged

Conversation

akyrtzi
Copy link
Contributor

@akyrtzi akyrtzi commented Jul 8, 2019

This is useful if you intend to have subclasses overriding specific methods of a common base SyntaxVisitor class.

It workarounds the issue of not being able to override the default implementations of the protocol (see https://bugs.swift.org/browse/SR-103).

@akyrtzi akyrtzi requested review from nkcsgexi and harlanhaskins July 8, 2019 21:26
This is useful if you intend to have subclasses overriding specific methods of a common base `SyntaxVisitor` class.
@akyrtzi akyrtzi force-pushed the syntaxvisitorclass branch from fc72f76 to ee7123b Compare July 8, 2019 21:40
@akyrtzi akyrtzi changed the title Introduce SyntaxVisitorClass Introduce SyntaxVisitorBase Jul 8, 2019
@akyrtzi
Copy link
Contributor Author

akyrtzi commented Jul 8, 2019

@swift-ci Please test

@akyrtzi akyrtzi merged commit a0ada01 into swiftlang:master Jul 8, 2019
@akyrtzi akyrtzi deleted the syntaxvisitorclass branch July 8, 2019 22:34
adevress pushed a commit to adevress/swift-syntax that referenced this pull request Jan 14, 2024
[NFC] Remove links to Google's style guide in comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants