Move raw syntax validation from gyb to code gen #1332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimdv
force-pushed
the
kimdv/move-raw-syntax-validation-from-gyb-to-code-gen
branch
from
e7c470c to
1a6a924
Compare
ahoppen
approved these changes
Feb 13, 2023
|
@swift-ci Please test |
|
Haven't run the code gen yet. |
|
Ah, I thought you did now because the generated file changed. Let me know when the multi-line string literal issue is fixed and this PR is ready for review. |
kimdv
force-pushed
the
kimdv/move-raw-syntax-validation-from-gyb-to-code-gen
branch
from
1a6a924 to
b8770fb
Compare
kimdv
force-pushed
the
kimdv/move-raw-syntax-validation-from-gyb-to-code-gen
branch
from
b8770fb to
f46d629
Compare
kimdv
force-pushed
the
kimdv/move-raw-syntax-validation-from-gyb-to-code-gen
branch
2 times, most recently
from
ef78caa to
d1f39ec
Compare
|
@swift-ci please test |
kimdv
force-pushed
the
kimdv/move-raw-syntax-validation-from-gyb-to-code-gen
branch
from
d1f39ec to
9a0941b
Compare
|
@swift-ci please test |
|
I think it's ready now @ahoppen 🥳 |
|
@swift-ci Please test macOS |
ahoppen
approved these changes
Feb 27, 2023
CodeGeneration/Sources/generate-swiftsyntax/templates/swiftsyntax/RawSyntaxValidationFile.swift
Show resolved
Hide resolved
CodeGeneration/Sources/generate-swiftsyntax/templates/swiftsyntax/RawSyntaxValidationFile.swift
Show resolved
Hide resolved
kimdv
deleted the
kimdv/move-raw-syntax-validation-from-gyb-to-code-gen
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last gym file 🥳
The removal of gym files will come in a follow up PR when this is merged