Fix multiline string when using string interpolation #1335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimdv
force-pushed
the
kimdv/fix-multi-line-string
branch
6 times, most recently
from
c5aea9e to
3b2d126
Compare
kimdv
force-pushed
the
kimdv/fix-multi-line-string
branch
6 times, most recently
from
c938faa to
51617e1
Compare
ahoppen
reviewed
Feb 22, 2023
CodeGeneration/Sources/generate-swiftsyntax/templates/basicformat/BasicFormatFile.swift
Outdated
Show resolved
Hide resolved
CodeGeneration/Sources/generate-swiftsyntax/templates/basicformat/BasicFormatFile.swift
Show resolved
Hide resolved
CodeGeneration/Sources/generate-swiftsyntax/templates/basicformat/BasicFormatFile.swift
Outdated
Show resolved
Hide resolved
kimdv
force-pushed
the
kimdv/fix-multi-line-string
branch
2 times, most recently
from
3d89fb1 to
b2a4a2c
Compare
kimdv
force-pushed
the
kimdv/fix-multi-line-string
branch
2 times, most recently
from
323bdbe to
020476f
Compare
ahoppen
approved these changes
Feb 23, 2023
| if let keyPath = getKeyPath(Syntax(node)), requiresLeadingNewline(keyPath), !(leadingTrivia.first?.isNewline ?? false) { | ||
| leadingTrivia = .newline + leadingTrivia | ||
| if let keyPath = getKeyPath(Syntax(node)), requiresLeadingNewline(keyPath), !(leadingTrivia.first?.isNewline ?? false), !shouldOmitNewline(node) { | ||
| leadingTrivia = .newline + leadingTrivia |
There was a problem hiding this comment.
You have hawk eyes! 👀
CodeGeneration/Sources/generate-swiftsyntax/templates/basicformat/BasicFormatFile.swift
Outdated
Show resolved
Hide resolved
CodeGeneration/Sources/generate-swiftsyntax/templates/basicformat/BasicFormatFile.swift
Show resolved
Hide resolved
kimdv
force-pushed
the
kimdv/fix-multi-line-string
branch
from
020476f to
cf28464
Compare
|
@swift-ci please test |
kimdv
force-pushed
the
kimdv/fix-multi-line-string
branch
from
cf28464 to
057a711
Compare
|
@swift-ci please test |
|
@swift-ci please test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some tests cases that fail and a single that pass