Skip to content

Implement parsing for _forget statement #1362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2023
Merged

Implement parsing for _forget statement #1362

merged 1 commit into from
Mar 1, 2023

Conversation

kavon
Copy link
Member

@kavon kavon commented Feb 26, 2023 •
edited
Loading

@kavon kavon requested a review from ahoppen as a code owner February 26, 2023 04:53
@kavon kavon changed the title Implement parsing for Implement parsing for _forget statement Feb 26, 2023
@kavon kavon marked this pull request as draft February 26, 2023 19:02
@kavon kavon mentioned this pull request Feb 27, 2023
Merged
@kavon kavon force-pushed the forget-statement branch 2 times, most recently from 979eca1 to f8e5b98 Compare February 28, 2023 02:16
@kavon kavon marked this pull request as ready for review February 28, 2023 05:30
ahoppen
ahoppen approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kavon kavon force-pushed the forget-statement branch from f8e5b98 to 67c66d5 Compare March 1, 2023 00:46
@kavon
Copy link
Member Author

kavon commented Mar 1, 2023

@swift-ci please test

@kavon kavon force-pushed the forget-statement branch 2 times, most recently from 6199af5 to c58de2d Compare March 1, 2023 04:41
@kavon
Copy link
Member Author

kavon commented Mar 1, 2023

@swift-ci please test and merge

@kavon
Copy link
Member Author

kavon commented Mar 1, 2023

@swift-ci please test

@kavon
Copy link
Member Author

kavon commented Mar 1, 2023

hm.

Detected unexpected failure: Timed out waiting for SourceKit response
  request: CursorInfo in /var/folders/pf/p5g2vb2j0yx1x6vlmxdppc700000gn/T/StressTesterToolTests/test.swift at offset 5 with args: /var/folders/pf/p5g2vb2j0yx1x6vlmxdppc700000gn/T/StressTesterToolTests/test.swift

@kavon
Copy link
Member Author

kavon commented Mar 1, 2023

@swift-ci please test

@kavon
implement parsing of forget statement
c9ba70f 
Currently staged in as `_forget` until we're ready to greenlight it.

The parsing uses one-token lookahead to disambiguate when someone
writes `forget(self)` to mean a function call, from `forget self`
to mean the actual forget statement.

More tests will be in the swift compiler repository.
@kavon kavon force-pushed the forget-statement branch from c58de2d to c9ba70f Compare March 1, 2023 15:52
@kavon
Copy link
Member Author

kavon commented Mar 1, 2023

@swift-ci please test

@kavon kavon merged commit 94b9021 into swiftlang:main Mar 1, 2023
@kavon kavon deleted the forget-statement branch March 2, 2023 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen ahoppen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kavon @ahoppen