Rename createUniqueName to makeUniqueName.
#1367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
rxwei
added a commit
to rxwei/swift
that referenced
this pull request
Feb 28, 2023
As per Evolution comment: https://forums.swift.org/t/se-0382-second-review-expression-macros/63064/20 To be merged with swiftlang/swift-syntax#1367
|
swiftlang/swift#63962 |
|
Let's stage this in so we don't break existing clients or require matched PRs. See my recent introduction of AbstractSourceLocation |
rxwei
force-pushed
the
rename-createuniquename
branch
from
b42ef5f to
f73e3f2
Compare
|
@swift-ci please smoke test |
|
Updated to define both as protocol requirements with each having a default implementation in terms the other. |
|
@swift-ci please smoke test |
DougGregor
approved these changes
Mar 6, 2023
|
@swift-ci please smoke test Linux |
|
@swift-ci please smoke test macOS |
|
@swift-ci please test |
|
Windows failure is unrelated. Merging to get closer to SE-0382. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per Evolution comment: https://forums.swift.org/t/se-0382-second-review-expression-macros/63064/20