Make generic API for binary operators #137
Merged
+23
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm new to gyb, but can we have python file which has a list of binary operators in SwiftSyntax side so that we can generate gyb files? |
|
What do you see the benefit of naming each one and not just use a generic version: ? |
# Conflicts: # Tests/SwiftSyntaxTest/SyntaxFactory.swift
|
I thought reserved binary operators can have explicit api, but generic one looks much better. |
kitasuke
changed the title
akyrtzi
approved these changes
Jul 25, 2019
|
@swift-ci Please test |
adevress
pushed a commit
to adevress/swift-syntax
that referenced
this pull request
Jan 14, 2024
Add `FileprivateAtFileScope` rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added generic API for binary operators so that it can make
TokenSyntaxfor any binary operator