[Variadic Generics] diagnostics + fixits for parameter pack syntax change: T... -> each T #1393
+120
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophiapoirier
force-pushed
the
type-parameter-pack-syntax-each-diagnostics
branch
3 times, most recently
from
04d361a to
a344469
Compare
ahoppen
approved these changes
Mar 10, 2023
| message: { _ in .typeParameterPackEllipsis } | ||
| ) | ||
| } else if let unexpected = node.unexpectedBetweenNameAndColon, | ||
| let unexpectedEllipsis = unexpected.onlyToken(where: { $0.tokenKind == .ellipsis }) { |
There was a problem hiding this comment.
Instead of force unwrapping below, I would add let each = node.each to the condition.
…tax change: T... -> each T
sophiapoirier
force-pushed
the
type-parameter-pack-syntax-each-diagnostics
branch
from
c62591a to
5cb534b
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brings parity with swiftlang/swift#64104 in the C++ implementation