Reduce recovery precedence of arrow in function type to exprKeyword #1399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
ahoppen
force-pushed
the
ahoppen/arrow-recovery-precedence
branch
from
c30d1c7 to
11a5cb4
Compare
|
@swift-ci Please test |
bnbarham
approved these changes
Mar 9, 2023
kimdv
reviewed
Mar 9, 2023
Only allow recovery to the arrow with exprKeyword precedence so we only skip over misplaced identifiers and don't e.g. recover to an errow in a 'where' clause. rdar://106457182
ahoppen
force-pushed
the
ahoppen/arrow-recovery-precedence
branch
from
11a5cb4 to
590ee43
Compare
|
@swift-ci Please test |
ahoppen
added a commit
to ahoppen/swift
that referenced
this pull request
Mar 10, 2023
The underlying issue should be fixed by swiftlang/swift-syntax#1399 rdar://106457182
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only allow recovery to the arrow with exprKeyword precedence so we only skip over misplaced identifiers and don't e.g. recover to an errow in a 'where' clause.
CC @StevenWong12 I didn’t think about this case when reviewing your PR.
rdar://106457182