[CompilerPlugin] Factor out message handling logic to a module #1403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
force-pushed
the
plugin-abstract
branch
from
479f43d to
fb67f74
Compare
|
@swift-ci Please test |
rintaro
force-pushed
the
plugin-abstract
branch
from
fb67f74 to
5dfa39d
Compare
|
@swift-ci Please test |
bnbarham
approved these changes
Mar 10, 2023
ahoppen
reviewed
Mar 10, 2023
There was a problem hiding this comment.
What do you think about naming the module SwiftCompilerPluginMessageHandling or something like that. I think that’s more descriptive than Impl. Also, I’m not sure whether we should underscore it because it seems equally useful to users as the other modules in swift-syntax.
Package.swift
Outdated
| @@ -43,6 +43,7 @@ let package = Package( | |||
| .library(name: "SwiftSyntaxParser", type: .static, targets: ["SwiftSyntaxParser"]), | |||
| .library(name: "SwiftSyntaxBuilder", type: .static, targets: ["SwiftSyntaxBuilder"]), | |||
| .library(name: "SwiftSyntaxMacros", type: .static, targets: ["SwiftSyntaxMacros"]), | |||
| .library(name: "_SwiftCompilerPluginBase", type: .static, targets: ["_SwiftCompilerPluginImpl"]), | |||
There was a problem hiding this comment.
The library is named differently than the target. Is that intentional?
Create a module '_SwiftCompilerPluginImpl' that abstracts the low level message connection/serilaization. 'CompilerPlugin' is now a implementation of the message connection, and adapts the concrete type to the message handler. This make it possible to make a plugin with a different messaging connection and serialization.
rintaro
force-pushed
the
plugin-abstract
branch
from
5dfa39d to
db609d6
Compare
|
Thank for naming idea. Let me go with |
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a module
_SwiftCompilerPluginImplthat abstracts the low level message connection/serialization.CompilerPluginis now an implementation of the message connection, and adapts the concrete type to the message handler.This make it possible to make a plugin with a different messaging connection and serialization.