Skip to content

Fix recovery for UTF-8 decoding of continuation byte #1430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 23, 2023
Merged

Fix recovery for UTF-8 decoding of continuation byte #1430

merged 2 commits into from
Mar 23, 2023

Conversation

hamishknight
Copy link
Contributor

Plus a couple of minor cleanups

@hamishknight hamishknight requested a review from ahoppen as a code owner March 22, 2023 22:15
ahoppen
ahoppen approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@hamishknight
Fix recovery for UTF-8 decoding of continuation byte
b949a7a 
The check here should be inverted.
@hamishknight
A couple of NFC cleanups
a9c5d95 
Remove an unused method, and remove some redundant
logic.
@hamishknight
Copy link
Contributor Author

@swift-ci please test

@hamishknight hamishknight merged commit 4e1a818 into swiftlang:main Mar 23, 2023
@hamishknight hamishknight deleted the misc branch March 23, 2023 20:50
@ahoppen ahoppen mentioned this pull request Mar 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen ahoppen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamishknight @ahoppen