[5.9] Fix missing diagnostics for multiple expressions on the same line in closures, switches, and getters #1458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think they were uppercase because they used to be called `XCTAssert*` but really it’s against all naming guidelines to start a Swift function with an uppercase letter.
…closures, switches, and getters Switch loops that used `parseCodeBlockItem` without semicolon checking over to using `parseCodeBlockItemList`.
Pass through `isAtTopLevel` and `allowInitDecl` parameters, which allow for better diagnostics.
hamishknight
force-pushed
the
outliner-5.9
branch
from
c9fba67 to
35a7334
Compare
|
@swift-ci please test |
ahoppen
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5.9 cherry-pick of #1453 + #1438
Low risk bug fix for a missing diagnostic.
Switch loops that used
parseCodeBlockItemwithout semicolon checking over to usingparseCodeBlockItemList.Resolves #1452
rdar://107265306