[Macros] Centralize "unwrapping" of errors into diagnostics. #1469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a few different implementations of "take an error thrown from a macro and turn it into diagnostics". Improve the implementation in `MacroExpansionContext.addDiagnostics` to properly handle both `DiagnosticsError` and `DiagnosticsMessage`, as well as fall back gracefully if either of those is missing an error diagnostic. Then, use that implementation for the compiler plugin message handler. Another part of fixing rdar://107289985, where diagnostics provided by throwing `DiagnosticsError` aren't coming through well.
|
@swift-ci please test |
|
@swift-ci please test macOS |
bnbarham
approved these changes
Mar 30, 2023
| // handle possibility that none of the diagnostics was an error | ||
| if !diagnosticsError.diagnostics.contains( | ||
| // Handle possibility that none of the diagnostics was an error. | ||
| if !diagnostics.contains( |
There was a problem hiding this comment.
Nice, this is actually used now for the DiagnosticMessage case 😅!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a few different implementations of "take an error thrown from a
macro and turn it into diagnostics". Improve the implementation in
MacroExpansionContext.addDiagnosticsto properly handle bothDiagnosticsErrorandDiagnosticsMessage, as well as fall backgracefully if either of those is missing an error diagnostic. Then,
use that implementation for the compiler plugin message handler.
Another part of fixing rdar://107289985, where diagnostics provided by
throwing
DiagnosticsErroraren't coming through well.