Move implementation of each case in SyntaxRewriter.doVisit to separate function #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e function In debug builds the compiler lays the stack space for each case statement out next to each other. This causes a call to doVisit(_:_:) to use ~50KB of stack space, quickly resulting in a stack overflow. Moving each implementation into its own function causes the each case to not use any stack space, circumventing the issue. <rdar://55929175> Fixes SR-11170
|
Based on some rough measurements, this also appears to give us a ~15% performance increase in release and ~35% performance increase in debug builds for the |
|
@swift-ci Please test |
benlangmuir
approved these changes
Oct 3, 2019
akyrtzi
approved these changes
Oct 3, 2019
adevress
pushed a commit
to adevress/swift-syntax
that referenced
this pull request
Jan 14, 2024
Use a location specific diagnostic message when the input is invalid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In debug builds the compiler lays the stack space for each case
statement out next to each other. This causes a call to doVisit(::) to
use ~50KB of stack space, quickly resulting in a stack overflow. Moving
each implementation into its own function causes the each case to not
use any stack space, circumventing the issue.
Fixes SR-11170