Skip to content

Only remove gyb-generated files that don't exist anymore #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2019

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Oct 8, 2019

If we delete all files, we are touching every file, causing a rebuild after every gyb-generation even if no file was changed.

If we delete all files, we are touching every file, causing a rebuild
after every gyb-generation even if no file was changed.
@ahoppen ahoppen requested a review from nkcsgexi October 8, 2019 20:34
@ahoppen
Copy link
Member Author

ahoppen commented Oct 8, 2019

@swift-ci Please test

Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thank you for fixing it!

@ahoppen ahoppen merged commit 0a55b1d into swiftlang:master Oct 8, 2019
@ahoppen ahoppen deleted the only-remove-deleted-files branch October 8, 2019 23:16
adevress pushed a commit to adevress/swift-syntax that referenced this pull request Jan 14, 2024
Support an ignore directive to ignore an entire file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants