Model SyntaxVisitor as a class #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
syntax-visitor-class
branch
2 times, most recently
from
9ee9449 to
11a32cf
Compare
|
@swift-ci Please test |
|
Build failed |
harlanhaskins
approved these changes
Oct 17, 2019
Avoid the overhead of existentials by modelling the entire syntax node hierarchy using structs with custom casting functions. This results in a major performance gain for SyntaxRewriter.
Improve the performance of SyntaxRewriter by avoiding unnecessary casts, reusing the SyntaxBox and eliminating .enumerated()
Refactor the implementation to match SyntaxRewriter, thereby gaining the same performance benefits.
Otherwise it requires a lot of boilerplate to return the Syntax node's type in the lit-test-helper.
Since all the methods on the SyntaxVisitor were mutating, it makes more sense to model the SyntaxVisitor as a class. This also increases visitation performance.
ahoppen
force-pushed
the
syntax-visitor-class
branch
from
11a32cf to
bc5fef3
Compare
|
@swift-ci Please test |
|
Build failed |
allevato
approved these changes
Oct 18, 2019
There was a problem hiding this comment.
The original change that turned SyntaxVisitor into a protocol caused an unfortunate (and large) amount of churn on swift-format's rule pipeline due to some tricky interactions between generics, protocols, and mutability. Even though it's a little sad to see all the work to fix that having to be reverted (we never migrated again to SyntaxVisitorBase), it's absolutely the right thing in the long run. 👍
nkcsgexi
approved these changes
Oct 22, 2019
2 tasks
adevress
pushed a commit
to adevress/swift-syntax
that referenced
this pull request
Jan 14, 2024
…ignores_discretionary Restore some discretionary newlines from PR swiftlang#143
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since all the methods on the SyntaxVisitor were mutating, it makes more sense to model the SyntaxVisitor as a class. This also increases visitation performance.
API Change
SyntaxVisitorSyntaxVisitorneed to become classesSyntaxAnyVisitorSyntaxAnyVisitorneed to become classesPerformance improvements
Performance measurements were done by running an empty
SyntaxRewriter/SyntaxVisitoron a Swift file with ~5000 lines of code. The baseline is the current performance of SwiftSyntax before #155 is merged.Empty
SyntaxVisitorEmpty
SyntaxAnyVisitor