Skip to content

SyntaxSupport Node Documentation: StructDecl #1589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2023
Merged

SyntaxSupport Node Documentation: StructDecl #1589

merged 1 commit into from
Apr 28, 2023

Conversation

andrewjl
Copy link
Contributor

@andrewjl andrewjl commented Apr 26, 2023 •
edited
Loading

andrewjl
andrewjl commented Apr 26, 2023
View reviewed changes
@andrewjl andrewjl force-pushed the ajlb/struct-decl-node-description branch from 07a8eb6 to 6d4f785 Compare April 28, 2023 04:26
ahoppen
ahoppen reviewed Apr 28, 2023
View reviewed changes
CodeGeneration/Sources/SyntaxSupport/DeclNodes.swift
mutating func pop() -> Element {
return items.removeLast()
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s nice and verbose. I like it 🤩

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@andrewjl andrewjl force-pushed the ajlb/struct-decl-node-description branch from 6d4f785 to 3439df4 Compare April 28, 2023 04:31
@ahoppen
Copy link
Member

ahoppen commented Apr 28, 2023

When you’re ready, you will need to re-generate files as described in https://swiftpackageindex.com/apple/swift-syntax/main/documentation/swiftsyntax/changingswiftsyntax. Let me know once you’ve done that and I’ll kick off CI for this PR.

@andrewjl andrewjl force-pushed the ajlb/struct-decl-node-description branch from 3439df4 to 34af691 Compare April 28, 2023 04:42
@andrewjl andrewjl marked this pull request as ready for review April 28, 2023 04:42
@andrewjl
Copy link
Contributor Author

andrewjl commented Apr 28, 2023 •
edited
Loading

When you’re ready, you will need to re-generate files as described in https://swiftpackageindex.com/apple/swift-syntax/main/documentation/swiftsyntax/changingswiftsyntax. Let me know once you’ve done that and I’ll kick off CI for this PR.

Done!

Edit: Since no nodes were added or removed I just ran: swift run --package-path CodeGeneration generate-swiftsyntax Sources.

ahoppen
ahoppen approved these changes Apr 28, 2023
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks!

@ahoppen
Copy link
Member

ahoppen commented Apr 28, 2023

@swift-ci Please test

@ahoppen ahoppen enabled auto-merge April 28, 2023 04:56
@ahoppen
Copy link
Member

ahoppen commented Apr 28, 2023

@swift-ci Please test Windows

@andrewjl
SyntaxSupport Node Documentation: StructDecl
6ca0913 
Add description to StructDecl and its children

Try to match TSPL conventions when discussing grammar

Include common structural (sorry) struct examples

Regenerate BuildableNodes
auto-merge was automatically disabled April 28, 2023 05:00

Head branch was pushed to by a user without write access

@andrewjl andrewjl force-pushed the ajlb/struct-decl-node-description branch from 34af691 to 6ca0913 Compare April 28, 2023 05:00
@ahoppen
Copy link
Member

ahoppen commented Apr 28, 2023

@swift-ci Please test

@andrewjl andrewjl changed the title Initial draft of StructDecl node descriptions SyntaxSupport Node Documentation: StructDecl Apr 28, 2023
@kimdv
Copy link
Contributor

kimdv commented Apr 28, 2023

@swift-ci please test

@ahoppen ahoppen merged commit 58509d1 into swiftlang:main Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen ahoppen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewjl @ahoppen @kimdv