[build-script] Unify configuration params into one toolchain param #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akyrtzi
approved these changes
Oct 25, 2019
This shifts the paradigm of the build script from specifying every executable manually to building SwiftSyntax using an existing toolchain. This goes in sync with building SwiftSyntax using swift_build_support in the main Swift repository.
ahoppen
force-pushed
the
build-script-toolchain
branch
from
54e98e4 to
94540cc
Compare
|
@swift-ci Please test |
|
Build failed |
|
Let’s try again, now that the bot for SwiftSyntax PR testing has been updated. @swift-ci Please test |
|
Build failed |
|
@swift-ci Please test |
|
Build failed |
|
@swift-ci Please test |
|
Build failed |
|
Re-triggering due to network outage. @swift-ci Please test |
dan-zheng
added a commit
to dan-zheng/swift
that referenced
this pull request
Nov 5, 2019
Related upstream patches: - swiftlang#27871 - swiftlang/swift-syntax#160
marcrasi
pushed a commit
to swiftlang/swift
that referenced
this pull request
Nov 5, 2019
Related upstream patches: - #27871 - swiftlang/swift-syntax#160
adevress
pushed a commit
to adevress/swift-syntax
that referenced
this pull request
Jan 14, 2024
Add back the short forms of `--mode` (`-m`) and `--version` (`-v`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shifts the paradigm of the build script from specifying every executable manually to building SwiftSyntax using an existing toolchain. This goes in sync with building SwiftSyntax using
swift_build_supportin the main Swift repository.