Skip to content

Update SwiftSyntax to Swift 5.7 #1627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Update SwiftSyntax to Swift 5.7 #1627

wants to merge 5 commits into from

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented May 2, 2023

Now that Xcode on CI nodes has been updated, we don’t need to support Swift 5.5 and 5.6 anymore.

  • Increase swift-tools-version to 5.7
  • Convert to shorthand if let notation
  • Migrate generics to opaque parameter types (aka. some types)
    • This was quite a lot of manual work
  • Remove @frozen attributes
    • These only existed as a workaround for a miscompute on Swift 5.5 and are no longer needed
  • Remove functions that only existed for Swift 5.6 compatibility
    • No longer needed

ahoppen added 4 commits May 1, 2023 19:55
@ahoppen
Increase swift-tools-version to 5.7
83a1f2d 
We no longer need to support building SwiftSyntax with Swift <5.7 so we can increase the tools version.

rdar://108753223
@ahoppen
Migrate SwiftSyntax to shorthand let notation
dc11f86
@ahoppen
Migrate generics to opaque parameter types where possible
5efff30
@ahoppen
Remove @frozen attributes
f819f2a 
These only existed to work around a miscompile in Swift 5.5. Since we no longer support it, we can remove the workaround
@ahoppen ahoppen requested review from rintaro and bnbarham May 2, 2023 02:59
@ahoppen ahoppen requested a review from DougGregor as a code owner May 2, 2023 02:59
@ahoppen
Copy link
Member Author

ahoppen commented May 2, 2023

@swift-ci Please test

kimdv
kimdv approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@kimdv kimdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WUHU!

@ahoppen ahoppen force-pushed the ahoppen/modern-swift branch from 49f9d95 to fae2ffa Compare May 2, 2023 17:39
@ahoppen
Copy link
Member Author

ahoppen commented May 2, 2023

@swift-ci Please test

@ahoppen
Copy link
Member Author

ahoppen commented May 2, 2023

@swift-ci Please test macOS

1 similar comment
@ahoppen
Copy link
Member Author

ahoppen commented May 4, 2023

@swift-ci Please test macOS

@ahoppen
Copy link
Member Author

ahoppen commented May 5, 2023

Since CI keeps failing for me on this one and I can’t reproduce the failure locally, I’m splitting this up to at least pinpoint which commit is causing the CI failure.

@ahoppen ahoppen marked this pull request as draft May 8, 2023 19:40
@ahoppen ahoppen closed this May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimdv kimdv kimdv approved these changes

@rintaro rintaro Awaiting requested review from rintaro rintaro is a code owner

@bnbarham bnbarham Awaiting requested review from bnbarham bnbarham is a code owner

@DougGregor DougGregor Awaiting requested review from DougGregor DougGregor is a code owner

@hamishknight hamishknight Awaiting requested review from hamishknight hamishknight will be requested when the pull request is marked ready for review hamishknight is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahoppen @kimdv