Make Syntax nodes conform to Identifiable

[ahoppen]

Since we already have a stable ID (SyntaxIdentifier), we can make the syntax nodes conform to Identifiable. Since Identifiable requires an id property, that property will become the canonical way of accessing the SyntaxIdentifier.

[ahoppen]

@swift-ci Please test

[ahoppen]

Also, I would like your feedback about whether deprecating uniqueIdentifier is the right way go or if we should just remove it since we have been breaking the API in the last weeks anyway.

[harlanhaskins]

I think it's fine to do that. The core team decided that id is a perfectly fine name for an identifier property, and it's in line with the expectations from Identifiable. Sounds good to me. Let's leave it deprecated because it doesn't harm anyone if it's there

[ahoppen]

I was thinking if we should just remove the uniqueIdentifier property straight away. At the moment I just deprecated it and forwarded the implementation to id.

[akyrtzi]

I'm fine with removing uniqueIdentifier, we already changed the API in more fundamental ways.
But we should start adding the changes compared to the last release in a document before we lose track..

[ahoppen]

@swift-ci Please test

[ahoppen]

I removed the uniqueIdentifier property and start gathering the changes I have made in an API changes document.