Get SwiftSyntax ready for building in a unified build with other projects #167
Conversation
|
@swift-ci Please test |
| env['SWIFT_SYNTAX_CI_ENVIRONMENT'] = '1' | ||
| env['SWIFT_BUILD_SCRIPT_ENVIRONMENT'] = '1' | ||
| # Tell other projects in the unified build to use local dependencies | ||
| env['SWIFTCI_USE_LOCAL_DEPS'] = '1' |
There was a problem hiding this comment.
Why do we need two environment variables instead of only one?
There was a problem hiding this comment.
My idea was that someone would still be able to build a non-build-script build (i.e. static libraries, no enforce-exclusivity=unchecked) while still using the already checked out sources.
Similarly when building the stress tester you might want to create a CI-style build without manually checking out SwiftSyntax etc. You could do that by specifying --no-local-dependencies on the stress tester's build script.
It just feels like these are two different things that we should not mush together into a single flag.
There was a problem hiding this comment.
Ok, sounds good, but then should SWIFTCI_USE_LOCAL_DEPS have a more general name, like SWIFT_BUILD_USE_LOCAL_DEPS or something, and not seem like it should be only set by the CI system?
There was a problem hiding this comment.
The name needs to match the one used in the Swift package manager here to avoid it from pulling in remote dependencies. I could go and change it there first.
There was a problem hiding this comment.
It's not important, the exact spelling doesn't matter much
There was a problem hiding this comment.
OK. I’ll just leave it as is for now then.
Fix for failing test.
Avoid recompiling SwiftSyntax for every project that depends on it by building all of these projects in a unified build.
This PR gets SwiftSyntax ready for the unified build by providing a
--multiroot-data-filecommand line option with which the workspace for the unified build can be specified. Furthermore it sets environment variables that configure the builds of downstream jobs to use local dependencies.See swiftlang/swift#28005