Skip to content

Add documentation to (nearly) all public functions in the SwiftSyntax module #1670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2023

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented May 16, 2023

Nothing more to say, really. Let’s write some documentation. Maybe, eventually, we can enable the swift-format rule that all public declarations must have a doc comment.

@ahoppen ahoppen requested review from rintaro and bnbarham May 16, 2023 04:45
@ahoppen
Copy link
Member Author

ahoppen commented May 16, 2023

@swift-ci Please test

Copy link
Contributor

@kimdv kimdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First, sorry for the ticks comments @ahoppen! 😁
I've added places where I think at would make sense to add them.

Feel free to just resolve them if you don't think they add value or sense.

@ahoppen ahoppen force-pushed the ahoppen/write-documentation branch from 3270330 to 2ae353f Compare May 16, 2023 19:50
@ahoppen
Copy link
Member Author

ahoppen commented May 16, 2023

Thanks for the review @kimdv. Adding double ticks definitely makes sense.

@ahoppen
Copy link
Member Author

ahoppen commented May 16, 2023

@swift-ci Please test

@kimdv
Copy link
Contributor

kimdv commented May 16, 2023

@swift-ci please test windows

@ahoppen ahoppen merged commit 967e487 into swiftlang:main May 24, 2023
@ahoppen ahoppen deleted the ahoppen/write-documentation branch May 24, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants