Skip to content

[5.9][Macros] Don't fold operators in unnecessary nodes #1676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2023
Merged

[5.9][Macros] Don't fold operators in unnecessary nodes #1676

merged 1 commit into from
May 18, 2023

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented May 18, 2023

Cherry-pick #1657 into release/5.9

  • Explanation: For attached macros, operator folding should only be done for the attribute syntax node, but not for the target declaration syntax and the parent decl syntax. This aligns with the compiler's ASTGen.
  • Scope: Macro executable plugin
  • Risk: Low. The change is small and straightforward, this is a new feature so nothing should depends on the old behavior
  • Testing: Passes current test suite
  • Issue: rdar://109494050
  • Reviwer: Ben Barham (@bnbarham), Doug Gregor (@DougGregor)

@rintaro
[Macros] Don't fold operators in unnecessary nodes
81e7687 
For attached macros, operator folding should only be done for the
attribute syntax node, but not for the target declaration syntax and
the parent decl syntax. This aligns with the compiler's ASTGen.

(cherry picked from commit d58ca93)
@rintaro rintaro requested a review from ahoppen as a code owner May 18, 2023 03:36
@rintaro
Copy link
Member Author

rintaro commented May 18, 2023

@swift-ci Please test

@rintaro rintaro merged commit 03cb7b0 into swiftlang:release/5.9 May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor DougGregor approved these changes

@ahoppen ahoppen Awaiting requested review from ahoppen ahoppen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rintaro @DougGregor