Improve diagnostics for invalid version tuples #1717
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TTOzzi
commented
May 31, 2023
ahoppen
reviewed
May 31, 2023
TTOzzi
force-pushed
the
remove-unexpected-node-between-argument-and-right-paren-in-attribute-syntax
branch
2 times, most recently
from
4a1a969 to
ee1bd18
Compare
TTOzzi
changed the title
TTOzzi
force-pushed
the
remove-unexpected-node-between-argument-and-right-paren-in-attribute-syntax
branch
from
ee1bd18 to
9ceda38
Compare
TTOzzi
commented
Jun 3, 2023
ahoppen
reviewed
Jun 7, 2023
| @@ -459,6 +459,29 @@ public class ParseDiagnosticsGenerator: SyntaxAnyVisitor { | |||
| ) | |||
| return .visitChildren | |||
| } | |||
| if let unexpectedBetweenArgumentAndRightParen = node.unexpectedBetweenArgumentAndRightParen, | |||
| var missingArgumentNode = node.argument?.missingNodes.only | |||
There was a problem hiding this comment.
missingNodes seems a little magical to me and I get the feeling that it’s not the right design because you need to patch it up further below. I think a better design would be to
- Modify the parser and eat e.g.
0xffas an unexpected token when parsing theVersionTupleSyntax. - Generate the diagnostic in
visit(_ node: VersionTupleSyntax)
There was a problem hiding this comment.
Aha I'll try again. Thanks for the feedback! 🙇
TTOzzi
changed the title
|
It looks like you have accidentally pulled in a few unrelated commits here |
|
I apologize profusely 😓 It appears that there might be an issue with my branch. |
TTOzzi
force-pushed
the
remove-unexpected-node-between-argument-and-right-paren-in-attribute-syntax
branch
from
2209cc8 to
dd976be
Compare
|
No worries! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1613