Functiontypesyntax.arguments should be named parameters
#1722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
ahoppen
approved these changes
Jun 2, 2023
There was a problem hiding this comment.
Thanks @AnthonyLatsis for reporting this and @kimdv for fixing it.
ahoppen
reviewed
Jun 2, 2023
Comment on lines
92
to
93
| @available(*, deprecated, renamed: "parameters") | ||
| var arguments: TupleTypeElementListSyntax { parameters } |
There was a problem hiding this comment.
Ah, I totally forgot that these properties also need to be settable. Would you mind also changing all the other properties in this compatibility layer to be settable?
kimdv
force-pushed
the
kimdv/1720-functiontypesyntaxarguments-should-be-named-parameters
branch
from
ccab20a to
aacf6b6
Compare
|
@swift-ci please test |
kimdv
changed the title
Functiontypesyntax.arguments should be named parameters
kimdv
deleted the
kimdv/1720-functiontypesyntaxarguments-should-be-named-parameters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1720