Skip to content

Change children naming inconsistencies between similar/dual syntax nodes #1730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

TTOzzi
Copy link
Member

@TTOzzi TTOzzi commented Jun 4, 2023

Resolve #1721

I have made the naming changes according to the comment I left on the issue.
If you have any feedback for better naming, please let me know and I will make the necessary updates 🙇‍♂️

@TTOzzi TTOzzi requested a review from ahoppen as a code owner June 4, 2023 08:37
@TTOzzi TTOzzi mentioned this pull request Jun 7, 2023
@TTOzzi TTOzzi force-pushed the change-children-naming-inconsistencies-between-similar-syntax-nodes branch 2 times, most recently from f563892 to 1e795e9 Compare June 8, 2023 13:34
@TTOzzi TTOzzi force-pushed the change-children-naming-inconsistencies-between-similar-syntax-nodes branch from 1e795e9 to ad2ae20 Compare June 8, 2023 13:47
@TTOzzi TTOzzi requested a review from ahoppen June 8, 2023 13:52
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ahoppen
Copy link
Member

ahoppen commented Jun 8, 2023

@swift-ci Please test

@ahoppen ahoppen enabled auto-merge June 8, 2023 17:08
@ahoppen ahoppen merged commit 6ff0671 into swiftlang:main Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Children naming inconsistencies between similar/dual syntax nodes
2 participants