Split SyntaxRewriter into three files #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
split-syntax-rewriter
branch
from
8cbf3d1 to
89db543
Compare
ahoppen
force-pushed
the
split-syntax-rewriter
branch
from
89db543 to
eef8258
Compare
ahoppen
changed the title
|
@swift-ci Please test |
akyrtzi
approved these changes
Nov 8, 2019
adevress
pushed a commit
to adevress/swift-syntax
that referenced
this pull request
Jan 14, 2024
Fix `@differentiable` attribute formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The three types
SyntaxRewriter,SyntaxVisitorandSyntaxAnyVisitorare not really tightly coupled and can be split into three different files. This makes the files easier to view in Xcode and decreases debug compile time by another 35% (30s vs 40s).